Skip to content

Conversation

@julian-cable
Copy link
Collaborator

No description provided.

@julian-cable julian-cable requested a review from daobrien December 8, 2021 15:18
@julian-cable julian-cable linked an issue Dec 8, 2021 that may be closed by this pull request
<!-- Not implementing this change for now.
<para>
In technical documentation, punctuation marks, including periods, commas, question marks, exclamation points, dashes, and semicolons go inside the quotation marks if they are part of the quotation; if not, they go outside.
In technical documentation, punctuation marks, including periods, commas, question marks, exclamation points, dashes, and semicolons go inside the quotation marks if they are part of the quotation or part of a programming element that uses quotation marks; if not, they go outside the quotation marks. If a sentence ends with a quotation, use only one punctuation mark to end the sentence, and place it inside the closing quotation mark if it is part of the quotation, or outside if it is not.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than "In technical documentation, punctuation marks,... go inside..." how about "In technical documentation, place punctuation marks,...inside..."
Also remember to continue with the "one sentence per line" guide to make reviews and edits easier. This is relatively new in the SG so you won't see a lot of it yet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with moving the verb earlier in the sentence.
Will note about one sentence per line.

<title>"That" in Clauses</title>
<para>
Include the word "that" in clauses unless it results in writing that is too formal or stilted. The use of the conjunction "that" makes the sentence easier to translate and improves clarity for readers whose primary language is not English,
Include the word "that" in clauses unless it results in writing that is too formal or stilted. The use of the conjunction "that" makes the sentence easier to translate and improves clarity for readers whose primary language is not English.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you fix this in #314 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this commit wasn't intentionally included in this issue.

Add examples of when to use or not to use quotation marks.
<example><title>Correct Examples of the Use of Punctuation with Quotation Marks</title>
<para>
For bind mounts, add "bind" and set fstype to "none".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fstype should be tagged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

In the program segment, ensure that the value is X'FF'.
</para>
<para>
If you use the keyword operand PGMID="PAYCOM", you must ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this example come from? I'm not sure how good of an example it is for what we're trying to demonstrate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It came from IBM Style. The idea was to show that the comma goes outside the quotation marks. I'll remove it and we have several other examples anyway.

Comment on lines 458 to 464
</para>
<para>
Julius Caesar said, “I came. I saw. I conquered.”
</para>
</example>

</section>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to stay on top of formatting, indentation, etc., when working in markup languages. It can make a difference to readability, troubleshooting, and in some cases (e.g., YAML) actual results.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my VS Code the indentation looks the same regardless of whether a leading tab or spaces are used. That appears not to be the case in this view, so I'm changing those lines to use a tab only.

Copy link
Contributor

@sffrench sffrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Julian.

@julian-cable julian-cable changed the title Jcable/297 punc quot Jcable/297 Change of standard for punctuation with quotation marks. Dec 22, 2021
Copy link
Collaborator

@daobrien daobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julian-cable julian-cable merged commit 3aa4f65 into dev Jan 11, 2022
@julian-cable julian-cable deleted the jcable/297-punc-quot branch January 11, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Punctuation with quotation marks

4 participants