-
Notifications
You must be signed in to change notification settings - Fork 21
Applied various fixes for 6.0 #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@daobrien @nmuller66 @sffrench These style guide fixes are ready for review. |
|
These fixes are for the upcoming October release 6.0 of the style guide. |
en-US/Grammar.xml
Outdated
| <entry> The <command>fsck</command> utility performs a file system verification on the XFS file system residing on the <filename>/dev/vdb1</filename> partition. </entry> | ||
| <entry> The <command>fsck</command> utility verifies the XFS file system on the <filename>/dev/vdb1</filename> partition. </entry> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is much better (I've been meaning to fix this for ages) but it's also not quite accurate. If you run fsck with no args it checks all file systems on all devices. If you want to check a specific file system then you have to pass it as an arg. E.g., fsck /dev/hd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the command to include arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small update to the example following Phil's feedback.
en-US/Grammar.xml
Outdated
| </row> | ||
| <row> | ||
| <entry> It is possible that the scheduled snapshot takes some time to be created. </entry> | ||
| <entry> Creating the scheduled snapshot might take time. </entry> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything takes time. Can we elaborate a bit? Something like "Creating the snapshot will take more or less time depending on the size of the system." Or maybe something different altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with a different example.
daobrien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en-US/Translation.xml
Outdated
| <!-- If you use DocBook or AsciiDoc to build itemized or ordered lists, you can choose between normal spacing or the <option>compact</option> attribute to specify the spacing between list items. | ||
| In AsciiDoc, compact spacing is not supported for variable (definition) lists. | ||
| DocBook and AsciiDoc use the <option>normal</option> spacing attribute by default. | ||
| <!-- In AsciiDoc? --> | ||
| DocBook and AsciiDoc use the <option>normal</option> spacing attribute by default. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you have specific reason for keeping it, just delete this and similar content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted
Addresses these issues:
#24
#79
#364
#369
#373
#404
#406