Skip to content

daobrien/456 vale check #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daobrien merged 4 commits into from
Feb 2, 2023
Merged

daobrien/456 vale check #462

daobrien merged 4 commits into from
Feb 2, 2023

Conversation

@daobrien
Copy link
Collaborator

@daobrien daobrien commented Feb 2, 2023

daobrien and others added 3 commits December 13, 2022 14:56
@daobrien
Merge pull request #447 from StyleGuides/dev
4fc1c91 
Merge all updates from dev to master for 6.0 release
Ongoing updates for #456
1de7eec
Closes #456
70453b7 
Part 2 of running Vale over the style guide.
I also addressed a few other issues along the way, such as one sentence per
line and removing old comments.

Language.xml in particular contains lots of examples of what not to do, so it
produces lots of noise in Vale.
julian-cable
julian-cable reviewed Feb 2, 2023
View reviewed changes
en-US/Language.xml Outdated
<para>
"Visit the following web link to dig deeper into [subject] ...". Using "dig deeper" may translate awkwardly. Consider rewording: "For detailed information regarding [subject], see [link]."
"Visit the following web link to dig deeper into [subject] ...".
Using "dig deeper" may translate awkwardly.
Copy link
Collaborator

@julian-cable julian-cable Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Using "dig deeper" may translate awkwardly.
Using "dig deeper" might translate awkwardly.

Copy link
Collaborator Author

@daobrien daobrien Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheesh. pick pick pick. That's supposed to fall under your bug of "follow our own rules" 😛

Copy link
Collaborator Author

@daobrien daobrien Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Collaborator

@julian-cable julian-cable Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that would fall under the banner of what Vale catches. And if it doesn't catch "may" already, maybe it should?

@daobrien daobrien merged commit 0acc4d3 into dev Feb 2, 2023
@daobrien daobrien deleted the daobrien/456-vale-check branch February 2, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julian-cable julian-cable julian-cable approved these changes

@sffrench sffrench Awaiting requested review from sffrench

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run Vale over the style guide Part 2

3 participants

@daobrien @julian-cable