Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second try of Add Czech suppport #149

Merged
merged 23 commits into from
Feb 7, 2023
Merged

Second try of Add Czech suppport #149

merged 23 commits into from
Feb 7, 2023

Conversation

kri164
Copy link
Contributor

@kri164 kri164 commented Jan 12, 2023

Abandon previous PR, please
This one is new and complete.
Thank you

Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for translating metadata, too! Btw, you can add more changes to this PR instead of creating a new one by pushing commits to your master branch, or editing files there from Github's website.

app/src/main/res/values/arrays.xml Outdated Show resolved Hide resolved
fastlane/metadata/android/cs-CZ/title.txt Outdated Show resolved Hide resolved
app/src/main/sentences/cs/lyrics.dslf Show resolved Hide resolved
app/src/main/sentences/cs/timer.dslf Outdated Show resolved Hide resolved
@kri164
Copy link
Contributor Author

kri164 commented Jan 12, 2023

Did correction, but dont know to commit/push it.
Look at fe4798e please.

@Stypox
Copy link
Owner

Stypox commented Jan 12, 2023

As you can read on the bottom of the page:

Add more commits by pushing to the master branch on kri164/dicio-android.

So you don't need to do anything specific to "push" something. Once you commit it to the master branch, it gets added here, too. So what you did is fine.

@Stypox
Copy link
Owner

Stypox commented Feb 6, 2023

@kri164 any news? Could you answer my comments?

@kri164
Copy link
Contributor Author

kri164 commented Feb 6, 2023 via email

@kri164 kri164 requested a review from Stypox February 7, 2023 08:35
Copy link
Owner

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :-D

@Stypox Stypox merged commit 451af28 into Stypox:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants