Allow users to import a custom wake word model #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is still necessary for users to generate the wake word model on their own, but now it is not necessary to recompile the app to use it.
This was referenced Feb 23, 2025
Closed
This allows the UI layer to listen to changes
|
I pushed a few commits which:
Other than that, thank you for this PR! The general approach was good, but I had to make some of the above changes to make the code modules more well separated and generalized. Debug APK: https://github.com/Stypox/testing-apks/releases/download/13/app-debug.apk (can be tested with models downloaded from https://github.com/dscripka/openWakeWord/releases/ ) |
Stypox
force-pushed
the
cskeggs-patch-3
branch
from
dc4d9f6 to
c664e15
Compare
- avoid having the view model access the specific wake word device instance (which may be recreated at any time) - make the methods to handle the custom model file static, so they can be used independently of the current wake word device
make it so that the text in the notification changes from `Listening for the "Hey Dicio" wake word` to `Listening for custom wake word` automatically
Stypox
force-pushed
the
cskeggs-patch-3
branch
from
c664e15 to
e7e6c15
Compare
celskeggs
commented
Mar 1, 2025
app/src/main/kotlin/org/stypox/dicio/io/wake/oww/OpenWakeWordDevice.kt
Outdated
Show resolved
Hide resolved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I can recompile Dicio myself to replace the wake word... it would be really nice if users could use a custom wake word more easily. This PR adds the ability to import a
.tflitefile to override the default downloaded "Hey Dicio" wake word.Generating a custom wake word is out of scope for the app, but users can download a model from the Home Assistant collection or use the OpenWakeWord scripts for training on Google Colab.
Fixes #289 #275 #238