-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add github actions for opa rego testing #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to the OPA ecosystem! Looks like a useful project 😃 Just a question/nit to address before we merge this.
Good work!
README.md
Outdated
@@ -300,6 +300,7 @@ A curated list of [awesome](https://github.com/sindresorhus/awesome) Open Policy | |||
- [gator CLI](https://open-policy-agent.github.io/gatekeeper/website/docs/gator/) - Command line unit test runner for OPA Gatekeeper | |||
- [ocov](https://github.com/C5T/ocov) - Colors `opa test --coverage` reports in the terminal | |||
- [opa-codecov](https://github.com/SVilgelm/opa-codecov) - Convert OPA test coverage report to a JSON format supported by Codecov | |||
- [GitHub Actions for OPA Rego Policy Test](https://github.com/masterpointio/github-action-opa-rego-test) - GitHub Action to automate testing for your OPA Rego policies and generates a report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the title of the project for the text here instead? I.e:
[github-action-opa-rego-test](https://github.com/masterpointio/github-action-opa-rego-test) - GitHub Action to automate testing for your OPA Rego policies and generate a report.
It feels like the text is mostly repeated in the description later anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Keeps it consistent as well. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also made a PR over here open-policy-agent/opa#6954
I believe you're a maintainer there as well? Would be nice to get it added there too! Thanks!
Thanks! 😃 |
GitHub Actions that automates testing OPA policies on GitHub and also generates a report including coverage and test results!