fix: log but don't send back file read errors in documentSymbol handle (

#678) Fixes #677 Signed-off-by: Anders Eknert <anders@styra.com>
StyraInc · Apr 24, 2024 · 55a1294 · 55a1294
1 parent 03c38aa
commit 55a1294
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/internal/lsp/server.go b/internal/lsp/server.go
@@ -746,12 +746,16 @@ func (l *LanguageServer) handleTextDocumentDocumentSymbol(
 
 	contents, ok := l.cache.GetFileContents(params.TextDocument.URI)
 	if !ok {
-		return nil, fmt.Errorf("failed to get file contents for uri %q", params.TextDocument.URI)
+		l.logError(fmt.Errorf("failed to get file contents for uri %q", params.TextDocument.URI))
+
+		return []types.DocumentSymbol{}, nil
 	}
 
 	module, ok := l.cache.GetModule(params.TextDocument.URI)
 	if !ok {
-		return nil, fmt.Errorf("failed to get module for uri %q", params.TextDocument.URI)
+		l.logError(fmt.Errorf("failed to get module for uri %q", params.TextDocument.URI))
+
+		return []types.DocumentSymbol{}, nil
 	}
 
 	return documentSymbols(contents, module), nil