Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate code lens doesn't work if input.json isn't found #1294

Closed
anderseknert opened this issue Dec 11, 2024 · 0 comments · Fixed by #1295
Closed

Evaluate code lens doesn't work if input.json isn't found #1294

anderseknert opened this issue Dec 11, 2024 · 0 comments · Fixed by #1295
Labels
bug Something isn't working language server protocol

Comments

@anderseknert
Copy link
Member

Not sure when this happened, but at least on current main, it seems like Evaluate only works when an input.json/yaml is found. Even when a rule that doesn't depend on the input is evaluated. We should fix this before next release.
@anderseknert anderseknert added bug Something isn't working language server protocol labels Dec 11, 2024
anderseknert added a commit that referenced this issue Dec 11, 2024
@anderseknert
Evaluate should work even when input missing
37c48f5 
Fixes #1294

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert mentioned this issue Dec 11, 2024
Merged
anderseknert added a commit that referenced this issue Dec 12, 2024
@anderseknert
Evaluate should work even when input missing
b0f082c 
Fixes #1294

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Dec 12, 2024
@anderseknert
Evaluate should work even when input missing
e7a038c 
Fixes #1294

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Dec 12, 2024
@anderseknert
Evaluate should work even when input missing
8e52767 
Fixes #1294

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Dec 12, 2024
@anderseknert
Evaluate should work even when input missing (#1295)
9102b94 
Fixes #1294

Signed-off-by: Anders Eknert <anders@styra.com>
charlieegan3 pushed a commit to charlieegan3/regal that referenced this issue Jan 6, 2025
@anderseknert @charlieegan3
Evaluate should work even when input missing (StyraInc#1295)
1168d80 
Fixes StyraInc#1294

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working language server protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Evaluate should work even when input missing StyraInc/regal
1 participant
@anderseknert