-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow enable/disable all via config file #153
Comments
Expanding on the scope a bit here as this was requested today, or at least something that is close enough. It'd be good if there was a way to freeze configuration of rules at any given point, so that updates wouldn't necessarily mean new rules automatically enabled. Some prefer to have them enabled manually, and that's obviously fine. I imagine this would look like:
Definitely open to alternative approaches if anyone has suggestions! |
I've been thinking some more about this, and I think a better design would be to mirror the rules:
'*':
level: ignore
bugs:
'*':
level: error
constant-condition:
level: ignore
testing:
print-or-trace-call:
level: error Disabling (i.e. setting level to I'm not too fond of using |
This PR implements an approach to rule defaulting described in: #153 (comment) Signed-off-by: Charlie Egan <charlie@styra.com>
This PR implements an approach to rule defaulting described in: #153 (comment) Signed-off-by: Charlie Egan <charlie@styra.com>
This PR implements an approach to rule defaulting described in: #153 (comment) Signed-off-by: Charlie Egan <charlie@styra.com>
* config: Support the defaulting of rules in config This PR implements an approach to rule defaulting described in: #153 (comment) Signed-off-by: Charlie Egan <charlie@styra.com> * Address linter and refactor Signed-off-by: Charlie Egan <charlie@styra.com> * Add e2e test for config defaulting and flag use Signed-off-by: Charlie Egan <charlie@styra.com> * Add new notes for defaulting in README Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Fixed in #587 |
* config: Support the defaulting of rules in config This PR implements an approach to rule defaulting described in: StyraInc#153 (comment) Signed-off-by: Charlie Egan <charlie@styra.com> * Address linter and refactor Signed-off-by: Charlie Egan <charlie@styra.com> * Add e2e test for config defaulting and flag use Signed-off-by: Charlie Egan <charlie@styra.com> * Add new notes for defaulting in README Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Since some users may want to only run a few rules in their repo, having to manually disable all the rules they don't care for is a bit of a chore. It'd be good if we allowed enabling/disabling all, or per category from the config as well.
The text was updated successfully, but these errors were encountered: