Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eval_conflict_error in ast.function_decls #168

Closed
anderseknert opened this issue Jun 21, 2023 · 0 comments · Fixed by #169
Closed

eval_conflict_error in ast.function_decls #168

anderseknert opened this issue Jun 21, 2023 · 0 comments · Fixed by #169
Labels
bug Something isn't working

Comments

@anderseknert
Copy link
Member

The ast.function_decls function will crash if there are more than one function declared with the same name in the AST 🤦 Not sure how this wasn't caught before, but during a refactor things started blowing up.
@anderseknert anderseknert added the bug Something isn't working label Jun 21, 2023
anderseknert added a commit that referenced this issue Jun 21, 2023
@anderseknert @srenatus
Don't crash on identically named functions
28fb0b5 
Fix ast.function_decls so that identically named functions
won't result in eval_conflict_error as the map is created

Fixes #168

Co-authored-by: Stephan Renatus <stephan@styra.com>
Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert mentioned this issue Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't crash on identically named functions StyraInc/regal
1 participant
@anderseknert