Remove uitable dependency #479
Labels
Comments
anderseknert
added a commit
that referenced
this issue
Nov 16, 2023
The compact format now uses a table with headings and borders as that actually looks better than what it used to, but the pretty format looks just as before. An unexpected optimization, I must say, but: ``` regal-table lint e2e/testdata/violations/most_violations.rego ran 1.09 ± 0.02 times faster than regal-main lint e2e/testdata/violations/most_violations.rego ``` That'll onlyu benefit project with many violations though ;) Fixes #479 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this issue
Nov 16, 2023
The compact format now uses a table with headings and borders as that actually looks better than what it used to, but the pretty format looks just as before. An unexpected optimization, I must say, but: ``` regal-table lint e2e/testdata/violations/most_violations.rego ran 1.09 ± 0.02 times faster than regal-main lint e2e/testdata/violations/most_violations.rego ``` That'll only benefit projects with many violations though ;) Fixes #479 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this issue
Nov 17, 2023
The compact format now uses a table with headings and borders as that actually looks better than what it used to, but the pretty format looks just as before. An unexpected optimization, I must say, but: ``` regal-table lint e2e/testdata/violations/most_violations.rego ran 1.09 ± 0.02 times faster than regal-main lint e2e/testdata/violations/most_violations.rego ``` That'll only benefit projects with many violations though ;) Fixes #479 Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this issue
Oct 1, 2024
The compact format now uses a table with headings and borders as that actually looks better than what it used to, but the pretty format looks just as before. An unexpected optimization, I must say, but: ``` regal-table lint e2e/testdata/violations/most_violations.rego ran 1.09 ± 0.02 times faster than regal-main lint e2e/testdata/violations/most_violations.rego ``` That'll only benefit projects with many violations though ;) Fixes StyraInc#479 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently use the https://github.com/gosuri/uitable package for printing the pretty and compact reports, which was simple to start with. Later on we introduced https://github.com/olekukonko/tablewriter as we needed to write the markdown table of rules in the README. This is a more competent table writer, and seemingly more performant too (can use
strings.Builderrather than abytes.Buffer) so it makes sense that we use that as our only dependency.Ideally we'll be able to use the same layout as we currently do for both output formats, but as long as things look good, I don't mind some changes.
The text was updated successfully, but these errors were encountered: