Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive in top-level-iteration when a ref var is imported #590

Closed
anderseknert opened this issue Mar 10, 2024 · 0 comments · Fixed by #592
Closed

False positive in top-level-iteration when a ref var is imported #590

anderseknert opened this issue Mar 10, 2024 · 0 comments · Fixed by #592
Labels
bug Something isn't working rule

Comments

@anderseknert
Copy link
Member 

package p

import data.x

y := input[x]

x is not an output var in this case, therefore there's no iteration. But looks like the top-level-iteration rule missed that. Not likely a common case but I found one in the wild today :)
@anderseknert anderseknert added bug Something isn't working rule labels Mar 10, 2024
anderseknert added a commit that referenced this issue Mar 11, 2024
@anderseknert
Fix false positive in rules not counting imports in scope
c5dce9e 
Fixes #590

That issue only mentions `top-level-iteration`, but I found
the same behavior in `use-some-for-output-vars`, so this fixes
that too.

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert mentioned this issue Mar 11, 2024
Merged
anderseknert added a commit that referenced this issue Mar 11, 2024
@anderseknert
Fix false positive in rules not counting imports in scope
27e0c0d 
Fixes #590

That issue only mentions `top-level-iteration`, but I found
the same behavior in `use-some-for-output-vars`, so this fixes
that too.

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Mar 11, 2024
@anderseknert
Fix false positive in rules not counting imports in scope (#592)
fff72d9 
Fixes #590

That issue only mentions `top-level-iteration`, but I found
the same behavior in `use-some-for-output-vars`, so this fixes
that too.

Signed-off-by: Anders Eknert <anders@styra.com>
srenatus pushed a commit to srenatus/regal that referenced this issue Oct 1, 2024
@anderseknert @srenatus
Fix false positive in rules not counting imports in scope (StyraInc#592)
76e664e 
Fixes StyraInc#590

That issue only mentions `top-level-iteration`, but I found
the same behavior in `use-some-for-output-vars`, so this fixes
that too.

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix false positive in rules not counting imports in scope StyraInc/regal
1 participant
@anderseknert