Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive in ignored-import when importing input (even though you shouldn't) #746

Closed
anderseknert opened this issue May 27, 2024 · 0 comments · Fixed by #747
Closed

False positive in ignored-import when importing input (even though you shouldn't) #746

anderseknert opened this issue May 27, 2024 · 0 comments · Fixed by #747
Labels
bug Something isn't working rule

Comments

@anderseknert
Copy link
Member

anderseknert commented May 27, 2024 •
edited
Loading 

package play

import rego.v1

import input

allow if input

This correctly flags the import of input, but it's not an ignored-import and shouldn't be flagged for that.
@anderseknert anderseknert added bug Something isn't working rule labels May 27, 2024
anderseknert added a commit that referenced this issue May 27, 2024
@anderseknert
Fix false positive when importing input/data in ignored-import
1aae2a4 
Fixes #746

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert mentioned this issue May 27, 2024
Merged
anderseknert added a commit that referenced this issue May 27, 2024
@anderseknert
Fix false positive when importing input/data in ignored-import (#747)
f0875e3 
Fixes #746

Signed-off-by: Anders Eknert <anders@styra.com>
srenatus pushed a commit to srenatus/regal that referenced this issue Oct 1, 2024
@anderseknert @srenatus
Fix false positive when importing input/data in ignored-import (Sty…
c337ecc 
…raInc#747)

Fixes StyraInc#746

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix false positive when importing input/data in ignored-import StyraInc/regal
1 participant
@anderseknert