Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completions: incorrect icons used in completions popup #755

Closed
anderseknert opened this issue May 27, 2024 · 0 comments · Fixed by #756
Closed

Completions: incorrect icons used in completions popup #755

anderseknert opened this issue May 27, 2024 · 0 comments · Fixed by #756
Labels
bug Something isn't working language server protocol

Comments

@anderseknert
Copy link
Member

A nit for sure, but looks like we no longer get the correct icons for the completion suggestions:

Screenshot 2024-05-27 at 21 35 56

(that's not the icon for a function)

Looking at the code, I think this comes from reusing symbols from the document/workspace symbols implementation, which while seemingly rational isn't the right mapping for completions, as they have a lookup table of their own.
@anderseknert anderseknert added bug Something isn't working language server protocol labels May 27, 2024
anderseknert added a commit that referenced this issue May 27, 2024
@anderseknert
Use completion item kind table for completions icons
9d0e2b7 
Fixes #755

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue May 27, 2024
@anderseknert
Use completion item kind table for completions icons
07b1496 
Fixes #755

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert mentioned this issue May 27, 2024
Merged
anderseknert added a commit that referenced this issue May 28, 2024
@anderseknert
Use completion item kind table for completions icons
6eb5c42 
Fixes #755

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue May 28, 2024
@anderseknert
Use completion item kind table for completions icons
43e6514 
Fixes #755

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue May 28, 2024
@anderseknert
Use completion item kind table for completions icons
2a8877c 
Fixes #755

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue May 28, 2024
@anderseknert
Use completion item kind table for completions icons (#756)
372185b 
Fixes #755

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue May 28, 2024
@anderseknert
Use completion item kind table for completions icons
44c6cc2 
Fixes #755

Signed-off-by: Anders Eknert <anders@styra.com>
srenatus pushed a commit to srenatus/regal that referenced this issue Oct 1, 2024
@anderseknert @srenatus
Use completion item kind table for completions icons (StyraInc#756)
fa5b34a 
Fixes StyraInc#755

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working language server protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use completion item kind table for completions icons StyraInc/regal
1 participant
@anderseknert