-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completions: incorrect icons used in completions popup #755
Labels
Comments
anderseknert
added a commit
that referenced
this issue
May 27, 2024
Fixes #755 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this issue
May 27, 2024
Fixes #755 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this issue
May 28, 2024
Fixes #755 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this issue
May 28, 2024
Fixes #755 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this issue
May 28, 2024
Fixes #755 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this issue
May 28, 2024
Fixes #755 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this issue
May 28, 2024
Fixes #755 Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this issue
Oct 1, 2024
Fixes StyraInc#755 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A nit for sure, but looks like we no longer get the correct icons for the completion suggestions:
(that's not the icon for a function)
Looking at the code, I think this comes from reusing symbols from the document/workspace symbols implementation, which while seemingly rational isn't the right mapping for completions, as they have a lookup table of their own.
The text was updated successfully, but these errors were encountered: