Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions: don't suggest refs from ignored files #766

Closed
charlieegan3 opened this issue May 29, 2024 · 3 comments · Fixed by #837
Closed

Completions: don't suggest refs from ignored files #766

charlieegan3 opened this issue May 29, 2024 · 3 comments · Fixed by #837

Comments

@charlieegan3
Copy link
Member

We will likely want to do this in the completions providers rather than in the indexing of refs since the refs might be handy for other things.

image

@charlieegan3
Copy link
Member Author

I feel like this is a trickier one, do we want to handle the case where a user can ignore linting but still wants completions?

I guess that ignoring files globally makes sense to follow if we update the docs to explain these will be ignored by completions in the language server too?

@anderseknert
Copy link
Member

anderseknert commented Jun 3, 2024

If you want to disable the linter, do that by disabling all rules rather than ignoring files:

rules:
  default:
    level: ignore

That'll give you no linting with all files still included by the language server for completions and whatnot. But yeah, making that clear in the docs if it isn't would be good!

@charlieegan3
Copy link
Member Author

Hmm, ok so now that we have ignore.files under rules, we can re-purpose ignore: the top level key for general/complete ignoring. Gotcha.

@anderseknert anderseknert moved this to TODO in Regal Jun 4, 2024
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jun 13, 2024
Fixes StyraInc#766

Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jun 13, 2024
Fixes StyraInc#766

Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jun 13, 2024
Fixes StyraInc#766

Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jun 13, 2024
Fixes StyraInc#766

Signed-off-by: Charlie Egan <charlie@styra.com>
@github-project-automation github-project-automation bot moved this from TODO to Done in Regal Jun 13, 2024
srenatus pushed a commit to srenatus/regal that referenced this issue Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants