-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completions: don't suggest refs from ignored files #766
Comments
I feel like this is a trickier one, do we want to handle the case where a user can ignore linting but still wants completions? I guess that ignoring files globally makes sense to follow if we update the docs to explain these will be ignored by completions in the language server too? |
If you want to disable the linter, do that by disabling all rules rather than ignoring files: rules:
default:
level: ignore That'll give you no linting with all files still included by the language server for completions and whatnot. But yeah, making that clear in the docs if it isn't would be good! |
Hmm, ok so now that we have ignore.files under rules, we can re-purpose |
Fixes StyraInc#766 Signed-off-by: Charlie Egan <charlie@styra.com>
Fixes StyraInc#766 Signed-off-by: Charlie Egan <charlie@styra.com>
Fixes StyraInc#766 Signed-off-by: Charlie Egan <charlie@styra.com>
Fixes StyraInc#766 Signed-off-by: Charlie Egan <charlie@styra.com>
…tyraInc#837) Fixes StyraInc#766 Signed-off-by: Charlie Egan <charlie@styra.com>
We will likely want to do this in the completions providers rather than in the indexing of refs since the refs might be handy for other things.
The text was updated successfully, but these errors were encountered: