Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: warn on != in iteration #79

Closed
anderseknert opened this issue Apr 10, 2023 · 0 comments · Fixed by #130
Closed

Rule: warn on != in iteration #79

anderseknert opened this issue Apr 10, 2023 · 0 comments · Fixed by #130
Labels
category/bugs rule

Comments

@anderseknert
Copy link
Member

Using != in iteration is almost always a bug:

"admin" != input.user.roles[_]

What was likely intended:

not "admin" in input.user.roles

Add to new category named "bugs".
anderseknert added a commit that referenced this issue May 26, 2023
@anderseknert
bugs/not-equals-in-loop
99a5101 
Like a few other rules, this won't catch all violations as
we don't yet traverse nested structures like comprehensions
or `every` constructs.

Fixes #79

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue May 26, 2023
@anderseknert
bugs/not-equals-in-loop
5382c15 
Like a few other rules, this won't catch all violations as
we don't yet traverse nested structures like comprehensions
or `every` constructs.

Fixes #79

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert mentioned this issue May 26, 2023
Merged
anderseknert added a commit that referenced this issue May 26, 2023
@anderseknert
bugs/not-equals-in-loop
6152d5b 
Like a few other rules, this won't catch all violations as
we don't yet traverse nested structures like comprehensions
or `every` constructs.

Fixes #79

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Jun 1, 2023
@anderseknert
bugs/not-equals-in-loop
ab1700d 
Like a few other rules, this won't catch all violations as
we don't yet traverse nested structures like comprehensions
or `every` constructs.

Fixes #79

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Jun 1, 2023
@anderseknert
bugs/not-equals-in-loop
4b36032 
Like a few other rules, this won't catch all violations as
we don't yet traverse nested structures like comprehensions
or `every` constructs.

Fixes #79

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Jun 1, 2023
@anderseknert
bugs/not-equals-in-loop (#130)
7518be5 
Like a few other rules, this won't catch all violations as
we don't yet traverse nested structures like comprehensions
or `every` constructs.

Fixes #79

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category/bugs rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugs/not-equals-in-loop StyraInc/regal
1 participant
@anderseknert