Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function arguments not considered by prefer-snake-case #942

Closed
anderseknert opened this issue Jul 26, 2024 · 0 comments · Fixed by #947
Closed

Function arguments not considered by prefer-snake-case #942

anderseknert opened this issue Jul 26, 2024 · 0 comments · Fixed by #947
Labels
bug Something isn't working rule

Comments

@anderseknert
Copy link
Member

For a policy like this:

package p

import rego.v1

fun(fooBar) := fooBar + 2

I expect fooBar to be flagged by the prefer-snake-case rule. But it seems like it isn't.
@anderseknert anderseknert added bug Something isn't working rule labels Jul 26, 2024
anderseknert added a commit that referenced this issue Jul 29, 2024
@anderseknert
Include function args in ast.vars (and prefer-snake-case rule)
221c503 
Fixes #942

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert mentioned this issue Jul 29, 2024
Merged
anderseknert added a commit that referenced this issue Jul 30, 2024
@anderseknert
Include function args in ast.vars (and prefer-snake-case rule)
088d1d9 
Also add end location to `prefer-snake-case` violations

Fixes #942

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Jul 30, 2024
@anderseknert
Include function args in ast.vars (and prefer-snake-case rule)
3fb68ae 
Also add end location to `prefer-snake-case` violations

Fixes #942

Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert added a commit that referenced this issue Jul 30, 2024
@anderseknert
Include function args in ast.vars (and prefer-snake-case rule)
83d1132 
Also add end location to `prefer-snake-case` violations

Fixes #942

Signed-off-by: Anders Eknert <anders@styra.com>
srenatus pushed a commit to srenatus/regal that referenced this issue Oct 1, 2024
@anderseknert @srenatus
Include function args in ast.vars (and prefer-snake-case rule) (S…
895f532 
…tyraInc#947)

Also add end location to `prefer-snake-case` violations

Fixes StyraInc#942

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include function args in ast.vars (and prefer-snake-case rule) StyraInc/regal
1 participant
@anderseknert