Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unable to match client identifier for initializing client" error for neovim #950

Closed
lemonshir opened this issue Jul 30, 2024 · 1 comment · Fixed by #951
Closed

"unable to match client identifier for initializing client" error for neovim #950

lemonshir opened this issue Jul 30, 2024 · 1 comment · Fixed by #951

Comments

@lemonshir
Copy link

Hi team, thanks a lot for your great work!

I noticed the following error when I opened the rego files with neovim via LspLog cmd:

[START][2024-07-30 16:32:55] LSP logging initiated
[ERROR][2024-07-30 16:32:55] .../vim/lsp/rpc.lua:770	"rpc"	"/Users/shir/.data/nvim/mason/bin/regal"	"stderr"	"ERROR: unable to match client identifier for initializing client, using generic functionality: Neovim\n"

It seems that the neovim is not identified as an supported client [1], so the error is raised here[2].

Is this the expected behavior?

[1] https://github.com/StyraInc/regal/blob/main/internal/lsp/clients/clients.go#L14
[2] https://github.com/StyraInc/regal/blob/main/internal/lsp/server.go#L1395

@charlieegan3
Copy link
Member

Hi there @lemonshir, thanks for your kind words about our project and for filing this issue.

The ERROR here is misleading, as nothing has gone wrong. using generic functionality is the operative phrase here, the server started ok and is operating as expected.

I think the correct action here is to just add Neovim to the list of known identifiers since nvim-lspconfig is a supported client our Regal LS.

charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jul 30, 2024
Fixes StyraInc#950

Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jul 30, 2024
Fixes StyraInc#950

Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jul 30, 2024
Fixes StyraInc#950

Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert pushed a commit to charlieegan3/regal that referenced this issue Jul 30, 2024
Fixes StyraInc#950

Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3 added a commit that referenced this issue Jul 30, 2024
Fixes #950

Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus pushed a commit to srenatus/regal that referenced this issue Oct 1, 2024
Fixes StyraInc#950

Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants