fix: don't serialize error location using roast but encoding/json #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
parse-error-unmarshalling
branch
from
976a890
to
b124064
Compare
Fixes #1017 Which turned into a bug hunt.. Also fixed: - ast.resolved_imports crashing on duplicate identifiers - node_modules not excluded from fs walk, as @srenatus reported Opening the OPA repo now works as expected. The 500+ linter issues notwithstanding. Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
parse-error-unmarshalling
branch
from
b124064
to
84b1bb1
Compare
anderseknert
changed the title
charlesdaniels
approved these changes
Aug 28, 2024
|
@charlesdaniels yeah, I guess the rule of three applies now.. I did look into that in the past but in the context of allowing providing that list via configuration... and that turned out to be complex. So they've remained hard-coded. You're right though — they could probably find a common location. I'll look into that next. |
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Fixes StyraInc#1017 Which turned into a bug hunt.. Also fixed: - ast.resolved_imports crashing on duplicate identifiers - node_modules not excluded from fs walk, as @srenatus reported Opening the OPA repo now works as expected. The 500+ linter issues notwithstanding. Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1017
Which turned into a bug hunt..
Also fixed:
Opening the OPA repo now works as expected. The 500+ linter issues notwithstanding.