fix: respect ref head rules in rule-name-repeats-package
#1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made some adjustments to make the rule follow more modern conventions, and more importantly, to report end locations. Fixes #1015 Signed-off-by: Anders Eknert <anders@styra.com>
charlieegan3
approved these changes
Aug 29, 2024
| possible_offending_prefixes contains prefix if { | ||
| some combination in possible_path_component_combinations | ||
| _possible_offending_prefixes contains prefix if { | ||
| some combination in _possible_path_component_combinations | ||
|
|
||
| prefix := concat("_", combination) |
There was a problem hiding this comment.
Should we also catch things like this with this rule?
package foo.bar
import rego.v1
foo.bar := trueThere was a problem hiding this comment.
Good question! I'd say no, as at least applying the same logic as we currently do for any path component would mean that something like:
package region.us.policies
user.permissions := { }Would count user as repeating us...
I think even for a simple naming scheme, this can sometimes be problematic. Like this one for example:
package my.db
dba if {
"dba" in input.user.roles
}A config toggle to only match full words would be nice. But it's also not a problem I've enountered in any real policy yet.
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
…1022) Also made some adjustments to make the rule follow more modern conventions, and more importantly, to report end locations. Fixes StyraInc#1015 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made some adjustments to make the rule follow more modern conventions, and more importantly, to report end locations.
Fixes #1015