Allow fixing directory structure not matching package paths #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
regal-fix-directories
branch
3 times, most recently
from
6c227b9 to
cbb257f
Compare
charlieegan3
reviewed
Sep 2, 2024
tmp/unrelated.txt
Outdated
| @@ -0,0 +1 @@ | |||
| foo | |||
There was a problem hiding this comment.
Certainly! I’m surprised there aren’t more given how many tempdirs I’ve burned in this process 😄 Thanks for catching that. Will fix!
charlieegan3
reviewed
Sep 2, 2024
| // FixResult is returned from the Fix method and contains the new contents or fix recommendations. | ||
| // In future this might support diff based updates, or renames. | ||
| // In future this might support diff based updates. |
anderseknert
force-pushed
the
regal-fix-directories
branch
6 times, most recently
from
4fa5b2b to
b4bd54a
Compare
Following the recent addition of the `directory-package-mismatch` rule, this PR brings a corresponding `regal fix` remediator as well as a code action to fix this directly in the editor. Fixes #1025 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
regal-fix-directories
branch
from
b4bd54a to
f5300df
Compare
|
Will defer docs to new PRs once this is in main. |
charlieegan3
approved these changes
Sep 3, 2024
anderseknert
added a commit
that referenced
this pull request
Sep 3, 2024
This is a follow-up PR to #1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this pull request
Sep 3, 2024
This is a follow-up PR to #1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this pull request
Sep 4, 2024
This is a follow-up PR to #1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this pull request
Sep 4, 2024
This is a follow-up PR to #1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this pull request
Sep 4, 2024
This is a follow-up PR to #1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this pull request
Sep 4, 2024
This is a follow-up PR to #1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
charlieegan3
pushed a commit
that referenced
this pull request
Sep 4, 2024
This is a follow-up PR to #1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this pull request
Sep 4, 2024
This is a follow-up PR to #1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
added a commit
that referenced
this pull request
Sep 4, 2024
This is a follow-up PR to #1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
…#1035) Following the recent addition of the `directory-package-mismatch` rule, this PR brings a corresponding `regal fix` remediator as well as a code action to fix this directly in the editor. Fixes StyraInc#1025 Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
…nc#1043) This is a follow-up PR to StyraInc#1035, documenting the new capabilities of Regal added there Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the recent addition of the
directory-package-mismatchrule, this PR brings a correspondingregal fixremediator as well as a code action to fix this directly in the editor.Fixes #1025
Todo:
opa.rootsas part of the init options, but what about updates?regal lintwe will need to either add a flag or read from config (or both)regal fix(including settings for DAS compliance)exclude-test-suffixor tofalseleads to no Code Action shownregal fix: determine if clean git working directory #1029regal fix--dry-runfor all fixes ofregal lint