lsp: Template new empty files & template on format #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
approved these changes
Sep 4, 2024
internal/lsp/server.go
Outdated
| @@ -1649,6 +1756,27 @@ func (l *LanguageServer) handleTextDocumentFormatting( | |||
| oldContent, ok = l.cache.GetFileContents(params.TextDocument.URI) | |||
| } | |||
|
|
|||
| // if the file is empty, then the formatters will fail, so we template | |||
| // intstead | |||
charlieegan3
force-pushed
the
template-formatting
branch
from
553d9e1
to
be4e6cb
Compare
Empty files will be created with a template content instead of being an error. New empty files will be immediately updated with the template content. Some client operations will not trigger the new file event, so in such cases, a save might be required to trigger the template update. Fixes StyraInc#1048 Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
template-formatting
branch
from
be4e6cb
to
197295c
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* lsp: Template new empty files & template on format Empty files will be created with a template content instead of being an error. New empty files will be immediately updated with the template content. Some client operations will not trigger the new file event, so in such cases, a save might be required to trigger the template update. Fixes StyraInc#1048 Signed-off-by: Charlie Egan <charlie@styra.com> * lsp: Add test for server templating Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty files will be created with a template content instead of being an error.
New empty files will be immediately updated with the template content.
Some client operations will not trigger the new file event, so in such cases, a save might be required to trigger the template update.
Fixes #1048
Screen.Recording.2024-09-04.at.15.45.42.mov