lsp: Always send empty diagnostics when deleted #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would only send empty diagnostics when the file had had diagnostics before, this did not include parse errors so when a file still had parse errors, it'd remain in client long after the server had cleared it.
anderseknert
approved these changes
Sep 9, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Previously, we would only send empty diagnostics when the file had had diagnostics before, this did not include parse errors so when a file still had parse errors, it'd remain in client long after the server had cleared it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would only send empty diagnostics when the file had had diagnostics before, this did not include parse errors so when a file still had parse errors, it'd remain in client long after the server had cleared it.
This PR also makes some changes to process the cases of clearing files outside the
l.diagnosticRequestFileloop as it was tricky to handle the types of empty updates in there.before
Screen.Recording.2024-09-09.at.14.24.20.mov
after
Screen.Recording.2024-09-09.at.14.25.09.mov