Fix issue where .manifest files didn't register as roots #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
manifest-root-unrecognized
branch
2 times, most recently
from
af52c86 to
15baf3d
Compare
anderseknert
force-pushed
the
manifest-root-unrecognized
branch
from
15baf3d to
52c30f9
Compare
We previously traversed the path downwards, so if we had `foo/bar/.manifest` and `foo/bar/baz` was provided, we would not find `foo/bar` as a root. Now search for manifests from the root. Fixes #1077 Signed-off-by: Anders Eknert <anders@styra.com>
charlieegan3
force-pushed
the
manifest-root-unrecognized
branch
from
52c30f9 to
86895bc
Compare
charlieegan3
approved these changes
Sep 9, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
We previously traversed the path downwards, so if we had `foo/bar/.manifest` and `foo/bar/baz` was provided, we would not find `foo/bar` as a root. Now search for manifests from the root. Fixes StyraInc#1077 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously traversed the path downwards, so if we had
foo/bar/.manifestandfoo/bar/bazwas provided, we would not findfoo/baras a root. Now search for manifests from the root.Fixes #1077