lsp: Rename on template #1085
Merged
lsp: Rename on template #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
force-pushed
the
rename-on-template
branch
2 times, most recently
from
cf79e48 to
dda1078
Compare
Fixes StyraInc#1061 Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
rename-on-template
branch
from
1137a6d to
39d5ee4
Compare
anderseknert
approved these changes
Sep 10, 2024
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
rename-on-template
branch
from
f6103cf to
41fdca7
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* lsp: Rename on template Fixes StyraInc#1061 Signed-off-by: Charlie Egan <charlie@styra.com> * lsp: template edits for rename in one operation Signed-off-by: Charlie Egan <charlie@styra.com> * lsp: Include deleting dirs as part of wksp changes Signed-off-by: Charlie Egan <charlie@styra.com> * lsp: templating add docs Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1061
Screen.Recording.2024-09-09.at.18.42.18.mov
I have added some tests for the templating, I was going to determine the desired name for the file in that function too but in the end it was easier to keep the renaming logic separate. Even if this is more verbose, can be revisited tomorrow if we want to do some tidying here. Posting now just to allow testing until I'm next back working on this.