-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regal eval:use-as-input
directive
#1088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
changed the title
Add regal eval:use-as-input directive
Add Sep 9, 2024
regal eval:use-as-input
directive
the evaluation feature automatically use the AST of the file as input. This allows building queries against the AST of | ||
the policy you're working on, providing an extremely fast feedback loop for developing new rules! | ||
|
||
![Use AST of file as input](./assets/lsp/eval_use_as_input.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to use the MDX version of these again right?
<img
src={require('./assets/lsp/diagnostics.png').default}
alt="Screenshot of diagnostics as displayed in Zed"/>
charlieegan3
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see comment about image in docs page.
This is a really nice feature!
Placing `# regal eval:use-as-input` as the top comment in any policy will now have the code lens eval feature automatically use the roAST of that file as input, allowing you to query the file as you work on it. Signed-off-by: Anders Eknert <anders@styra.com>
A "comment block" should only count comments in sequence when they are on the same column. Fixes #1086 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
eval-use-as-input
branch
from
September 10, 2024 08:49
ca8e36e
to
b26cbe9
Compare
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Sep 10, 2024
Related StyraInc#1088 Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
pushed a commit
that referenced
this pull request
Sep 10, 2024
Related #1088 Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Placing `# regal eval:use-as-input` as the top comment in any policy will now have the code lens eval feature automatically use the roAST of that file as input, allowing you to query the file as you work on it. Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Related StyraInc#1088 Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placing
# regal eval:use-as-input
as the top comment in any policy will now have the code lens eval feature automatically use the roAST of that file as input, allowing you to query the file as you work on it.