Add source action to explore compiler stages #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
opa-explorer
branch
from
ad30ec0 to
949267d
Compare
anderseknert
changed the title
charlieegan3
approved these changes
Sep 11, 2024
srenatus
approved these changes
Sep 11, 2024
srenatus
reviewed
Sep 11, 2024
srenatus
reviewed
Sep 11, 2024
srenatus
reviewed
Sep 11, 2024
| cache *cache.Cache | ||
| workspaceURI string | ||
| client clients.Identifier | ||
| baseURL string |
There was a problem hiding this comment.
I think this could be racy: we're setting the baseURL from a goroutine, but we retrieve it from GetBaseURL. It's probably unlikely to be a problem in real world usage, since it involves user interactions, though. OTOH adding a mutex should be simple enough.
This PR integrates @srenatus excellent [opa-explorer](https://github.com/srenatus/opa-explorer/) with Regal, where we now start a web server along with the language server to host the explorer. Users will now see a "Source Action" in the context menu of any given Rego file, and when clicked will bring them to the explorer view for that file. Since a command for opening web pages client side is AFAIK only available in VS Code, this feature is sadly limited to that editor currently. Perhaps we can figure out some way to have the link show in Zed, similar to what we did for linter docs? For now, we're only loading a single file into the explorer for compilation. We could perhaps consider loading all modules in the workspace too, as otherwise compilation will always fail on e.g. unknown functions from outside the policy. Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
opa-explorer
branch
from
949267d to
03ce353
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
This PR integrates @srenatus excellent [opa-explorer](https://github.com/srenatus/opa-explorer/) with Regal, where we now start a web server along with the language server to host the explorer. Users will now see a "Source Action" in the context menu of any given Rego file, and when clicked will bring them to the explorer view for that file. Since a command for opening web pages client side is AFAIK only available in VS Code, this feature is sadly limited to that editor currently. Perhaps we can figure out some way to have the link show in Zed, similar to what we did for linter docs? For now, we're only loading a single file into the explorer for compilation. We could perhaps consider loading all modules in the workspace too, as otherwise compilation will always fail on e.g. unknown functions from outside the policy. Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates @srenatus excellent opa-explorer with Regal, where we now start a web server along with the language server to host the explorer.
Users will now see a "Source Action" in the context menu of any given Rego file, and when clicked will bring them to the explorer view for that file.
Since a command for opening web pages client side is AFAIK only available in VS Code, this feature is sadly limited to that editor currently. Perhaps we can figure out some way to have the link show in Zed, similar to what we did for linter docs?
For now, we're only loading a single file into the explorer for compilation. We could perhaps consider loading all modules in the workspace too, as otherwise compilation will always fail on e.g. unknown functions from outside the policy.