Add Debug Code Lens
#1103
Add Debug Code Lens
#1103
Conversation
.vscode/settings.json
Outdated
| @@ -4,6 +4,7 @@ | |||
| "OPA_EVAL_CAPABILITIES": "${workspacePath}/build/capabilities.json" | |||
| }, | |||
| "opa.roots": [ | |||
| "${workspaceFolder}/lab", | |||
There was a problem hiding this comment.
No, thanks! Removed. Although it is rather tricky to get it right with the "checkOnSave" feature when you want it outside of the main bundle but not the whole workspace... I'll guess I'll have to do some git magic to make sure this line remains unseen. I've removed it from the change now anyway.
| break | ||
| } | ||
|
|
||
| if len(params.Arguments) != 3 { |
There was a problem hiding this comment.
I don't see us reading arg 2 anywhere. Looks like it's the line number for regal.eval, which I suppose we don't need for debug. Do we still need to assert its presence?
There was a problem hiding this comment.
No, you're right, we don't need to assert this here, but we're using the same outputs for both code lenses... and we'll want to check this to avoid getting out of bounds errors in case there aren't at least 2 args.
| _debug_lenses contains { | ||
| "range": location.to_range(result.ranged_location_from_text(input["package"]).location), | ||
| "command": { | ||
| "title": "Debug", |
There was a problem hiding this comment.
Does vscode support emojis? If it does, we could prefix this with a '🪲' 😄.
There's probably plenty of setups where that would break, though.
There was a problem hiding this comment.
It does support that, and since we're only targeting VS Code for now, we could do it. Not sure this is intuitive though. Most people will probably think they got some dirt on their monitor 🤣
There was a problem hiding this comment.
I was thinking something like ►Evaluate|🪲Debug
| _debug_lenses contains _rule_lens(rule, "regal.debug", "Debug") if { | ||
| some rule in ast.rules | ||
|
|
||
| # no need to add a debug lens for a rule like `pi := 3.14`` |
Following the excellent work on debugger support by @johanfylling, this PR introduces a code lens for debugging, which triggers a command that simply returns a launch configuration where the package or rule clicked is set as the entrypoint. The code lens provider is now also rewritten in Rego. Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
debug-lens
branch
from
d3f1164
to
822caf9
Compare
Following the excellent work on debugger support by @johanfylling, this PR introduces a code lens for debugging, which triggers a command that simply returns a launch configuration where the package or rule clicked is set as the entrypoint. The code lens provider is now also rewritten in Rego. Signed-off-by: Anders Eknert <anders@styra.com>
Following the excellent work on debugger support by @johanfylling, this PR introduces a code lens for debugging, which triggers a command that simply returns a launch configuration where the package or rule clicked is set as the entrypoint.
The code lens provider is now also rewritten in Rego.