Use betteralign for struct alignment #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
commented
Sep 24, 2024
pkg/reporter/reporter_test.go
Outdated
| @@ -255,6 +255,16 @@ func TestJSONReporterPublish(t *testing.T) { | |||
| expect := `{ | |||
| "violations": [ | |||
| { | |||
| "location": { | |||
There was a problem hiding this comment.
If we don't like the JSON output changed, we can easily create a custom serializer with jsoniter
charlieegan3
approved these changes
Sep 24, 2024
|
@charlieegan3 there used to be an |
Saving us some bytes ;) A few things had to be fixed, but nothing I'd consider breaking. Signed-off-by: Anders Eknert <anders@styra.com> # Conflicts: # internal/lsp/completions/providers/options.go # internal/lsp/server.go
anderseknert
force-pushed
the
betteralign
branch
from
af988c1 to
ba9b4a6
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Saving us some bytes ;) A few things had to be fixed, but nothing I'd consider breaking. Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving us some bytes ;) A few things had to be fixed, but nothing I'd consider breaking.
Not too important though, so happy to close if someone else is concerned :P