bundle: Load bundle once #1136
Merged
bundle: Load bundle once #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
commented
Sep 25, 2024
| @@ -102,8 +100,8 @@ func (l Linter) WithInputModules(input *rules.Input) Linter { | |||
| } | |||
|
|
|||
| // WithAddedBundle adds a bundle of rules and data to include in evaluation. | |||
| func (l Linter) WithAddedBundle(b bundle.Bundle) Linter { | |||
| l.ruleBundles = append(l.ruleBundles, &b) | |||
| func (l Linter) WithAddedBundle(b *bundle.Bundle) Linter { | |||
There was a problem hiding this comment.
This is an API change. We can do it without this, but it feels right to do it given how this function is used.
There was a problem hiding this comment.
This is not used in the Rego playground or in any public code on https://sourcegraph.com/search?q=context:global+WithAddedBundle&patternType=keyword&sm=0
charlieegan3
force-pushed
the
load-bundle-once
branch
from
4746212 to
e0f22d9
Compare
srenatus
reviewed
Sep 25, 2024
bundle/bundle.go
Outdated
| loadedBundleOnce sync.Once | ||
| ) | ||
|
|
||
| // LoadedBundle returns the loaded Regal bundle for this version of Regal. |
There was a problem hiding this comment.
I take it you'd like to keep it being lazily loaded? Because if it was going to be used anyways, often times sync.Once etc can be replaced with a package var, like
var loadedBundle = io.MustLoadRegalBundleFS(Bundle)There was a problem hiding this comment.
Perhaps we should just do this 👍 I was remembering a discussion about how inits in the ls implementation were slowing down the linting cmd, but that's not the case here.
Previously, loading of the bundle happened many times, each time it takes around 20ms. This improves the performance of the language server by loading the bundle once and reusing it since the bundle is never changed once a binary is running. Signed-off-by: Charlie Egan <charlie@styra.com>
Follows PR review comment Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
load-bundle-once
branch
from
e0f22d9 to
9c2e409
Compare
srenatus
approved these changes
Sep 25, 2024
|
Thanks Stephan! |
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* bundle: Load bundle once Previously, loading of the bundle happened many times, each time it takes around 20ms. This improves the performance of the language server by loading the bundle once and reusing it since the bundle is never changed once a binary is running. Signed-off-by: Charlie Egan <charlie@styra.com> * bundle: use pkg var Follows PR review comment Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
* bundle: Load bundle once Previously, loading of the bundle happened many times, each time it takes around 20ms. This improves the performance of the language server by loading the bundle once and reusing it since the bundle is never changed once a binary is running. Signed-off-by: Charlie Egan <charlie@styra.com> * bundle: use pkg var Follows PR review comment Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, loading of the bundle happened many times, each time it takes around 20ms. This improves the performance of the language server by loading the bundle once and reusing it since the bundle is never changed once a binary is running.
before
Screen.Recording.2024-09-25.at.10.19.12.mov
after
Screen.Recording.2024-09-25.at.10.20.29.mov