Fix detached-metadata issues
#1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,3 +28,16 @@ _annotation_at_row(row) := annotation if { | |||
|
|
|||
| util.to_location_object(annotation.location).row == row | |||
| } | |||
|
|
|||
| _allow_detached(last_row, i, blocks, lines) if { | |||
There was a problem hiding this comment.
I understand this now, but a comment might be helpful in a few months time! 😅
There was a problem hiding this comment.
Sure! :) I'll add one 👍
charlieegan3
approved these changes
Sep 26, 2024
Build a more robust system for determining this regardless of scope. Lean in on the OPA parser failing anyway when scope is invalid. Fixes #1138 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
detached-package-scope
branch
from
8cd68e3 to
d8bbbd3
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Build a more robust system for determining this regardless of scope. Lean in on the OPA parser failing anyway when scope is invalid. Fixes StyraInc#1138 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build a more robust system for determining this regardless of scope. Lean in on the OPA parser failing anyway when scope is invalid.
Fixes #1138