fix: fix var name for commit hash used for version
subcommand
#1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that
regal version
subcommand does not show commit hash.This is because the build time information is passed to
pkg/version.Commit
variable, but it does not exist there.regal/.goreleaser.yaml
Line 24 in e205cd9
I fixed this problem by renaming
pkg/version.Vcs
topkg/version.Commit
.❯ go build -ldflags='-X github.com/styrainc/regal/pkg/version.Commit=my-commit' ❯ ./regal version Version: unknown Go Version: go1.22.7 Platform: linux/amd64 Commit: my-commit Timestamp: unknown Hostname: unknown