lsp: enable levelled logging #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levels can be used to control how verbose the server logging is. Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been having a hard time debugging test suite issues like this one: https://github.com/StyraInc/regal/actions/runs/11233013451/job/31225814604 where the order of events doesn't appear to follow the order expected based on the implementation.
This PR makes an improvement to the Language Server to support logging of messages at different levels.
This retains the old behaviour in a new model, but then also adds a number of debug messages for requests and diagnostics jobs to aid in debugging tests.
In future, we may wish for more log levels, but for now, I have used the three available in the LSP TraceValues.