Use filepath.WalkDir instead of filepath.Walk #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the benefit of not having to stat all files along the way. Ideally, we'd be able to build the data bundle in the same function more efficiently too, but that's a more complex operation. Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
tiny-perf-win
branch
from
fa4fca7 to
857b5ab
Compare
charlieegan3
pushed a commit
to charlieegan3/regal
that referenced
this pull request
Jan 6, 2025
This has the benefit of not having to stat all files along the way. Ideally, we'd be able to build the data bundle in the same function more efficiently too, but that's a more complex operation. Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the benefit of not having to stat all files along the way.
Ideally, we'd be able to build the data bundle in the same function more efficiently too, but that's a more complex operation.