lint/rpt: Handle no-color ttys #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
approved these changes
Oct 21, 2024
charlieegan3
force-pushed
the
no-color
branch
2 times, most recently
from
7fac2f6 to
2523f6e
Compare
srenatus
reviewed
Oct 21, 2024
pkg/reporter/reporter.go
Outdated
| // if there is no support for color, then we show the level in addition | ||
| // so that the level of the violation is still clear | ||
| if color.NoColor { | ||
| table.Append([]string{yellow("Level:"), violation.Level}) |
There was a problem hiding this comment.
Feels a little odd to use yellow() here, doesn't it? 🤔
There was a problem hiding this comment.
Have updated this now
This fixes StyraInc#1211 by supporting the NO_COLOR environment variable and checking if the output is a tty before using color. The color.NoColor global is used as described here: https://github.com/fatih/color?tab=readme-ov-file#disableenable-color Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
no-color
branch
from
2523f6e to
95a5fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1211 by supporting the NO_COLOR environment variable and checking if the output is a tty before using color.
The color.NoColor global is used as described here: https://github.com/fatih/color?tab=readme-ov-file#disableenable-color