Rule: duplicate-rule
#530
Merged
Rule: duplicate-rule
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Remove whitespace from textual representation of rule and create a hash from the result. | ||
| # This provides a decent, and importantly *cheap*, approximation of duplicates. We can then | ||
| # parse the text of these suspected duplicate rules to get a more exact result. | ||
| rules_hashed := [crypto.md5(regex.replace(text, `\s`, "")) | some text in rules_as_text] |
There was a problem hiding this comment.
Suggested change
| rules_hashed := [crypto.md5(regex.replace(text, `\s`, "")) | some text in rules_as_text] | |
| rules_hashed := [crypto.md5(regex.replace(text, `\s+`, "")) | some text in rules_as_text] |
Might be a tiny bit faster?
As the name implies, flag duplicate rules when found. See the docs included in the PR for more details, including current limitations. This rule should be an aggregate rule, but it was hairy enough to pull off with a single file scope, so I decided to hold off on that for now. This provides value already, so let's ship it and consider looking into making this aggregate later. Fixes #427 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
duplicate-rule
branch
from
36261f5
to
26d5128
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
As the name implies, flag duplicate rules when found. See the docs included in the PR for more details, including current limitations. This rule should be an aggregate rule, but it was hairy enough to pull off with a single file scope, so I decided to hold off on that for now. This provides value already, so let's ship it and consider looking into making this aggregate later. Fixes StyraInc#427 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the name implies, flag duplicate rules when found. See the docs included in the PR for more details, including current limitations.
This rule should be an aggregate rule, but it was hairy enough to pull off with a single file scope, so I decided to hold off on that for now. This provides value already, so let's ship it and consider looking into making this aggregate later.
Fixes #427