Rule: use-rego-v1
#538
Merged
Rule: use-rego-v1
#538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
reviewed
Feb 5, 2024
docs/rules/imports/use-rego-v1.md
Outdated
| ```rego | ||
| package policy | ||
|
|
||
| # before OPA v0.59.0, this is alright |
There was a problem hiding this comment.
Suggested change
| # before OPA v0.59.0, this is alright | |
| # before OPA v0.59.0, this was best practice |
charlieegan3
reviewed
Feb 5, 2024
docs/rules/imports/use-rego-v1.md
Outdated
| ## Rationale | ||
|
|
||
| OPA [v0.59.0](https://github.com/open-policy-agent/opa/releases/tag/v0.59.0) introduced a new `rego.v1` import, which | ||
| allows policy authors to prepare for language changes coming in a future OPA 1.0 release. Some notable changes include: |
There was a problem hiding this comment.
Suggested change
| allows policy authors to prepare for language changes coming in a future OPA 1.0 release. Some notable changes include: | |
| allows policy authors to prepare for language changes coming in the future OPA 1.0 release. Some notable changes include: |
charlieegan3
approved these changes
Feb 5, 2024
| ```shell | ||
| $ regal lint bundle | ||
| 131 files linted. No violations found. 1 rule skipped: | ||
| - use-rego-v1: Missing capability for `import rego.v1` |
Recommend using `import rego.v1`. Also: * Ignore `import future` rules when `rego.v1` rule in capabilities * Update the documentation for all rules to use the `rego.v1` import * Update all Rego used in tests to use `rego.v1` import Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
use-rego-v1
branch
from
5eabcd0
to
e8b328d
Compare
Closed
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Recommend using `import rego.v1`. Also: * Ignore `import future` rules when `rego.v1` rule in capabilities * Update the documentation for all rules to use the `rego.v1` import * Update all Rego used in tests to use `rego.v1` import Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend using
import rego.v1.Also:
import futurerules whenrego.v1rule in capabilitiesrego.v1importrego.v1import