Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule: with-outside-test-context #555

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Rule: with-outside-test-context #555

merged 1 commit into from
Feb 15, 2024

Conversation

anderseknert
Copy link
Member

@anderseknert anderseknert commented Feb 14, 2024

See docs in PR for description.

This also introduces a new performance category.

Fixes #548

@anderseknert anderseknert linked an issue Feb 14, 2024 that may be closed by this pull request
Base automatically changed from go-linter-fixes to main February 14, 2024 09:40
Copy link
Member

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about this!

@anderseknert
Copy link
Member Author

anderseknert commented Feb 15, 2024

@charlieegan3 I knew with wasn’t very performant, but it was an example from @robhafner that made me realize just how problematic it can be. Good that get that knowledge into Regal!

This also introduces a new `performance` category.

Fixes #548

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert merged commit 22f6a10 into main Feb 15, 2024
3 checks passed
@anderseknert anderseknert deleted the with-outside-test branch February 15, 2024 14:42
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
This also introduces a new `performance` category.

Fixes StyraInc#548

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rule: with-outside-test
2 participants