rules: Add double negative rule #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
double-negative
branch
from
c8dd260
to
4a60f6c
Compare
|
Maybe... I think it's enough of a smell to leave it in though. For other custom rules we generally have some clear examples where it'd be a bad idea to turn on but I can't think of them here. not not_foo is just always bad as I see it. Maybe we'll have some community members with some good counter examples, but for now I think it's good enough to have in the default list. |
|
Alright, perhaps you're right. I'll have some time to ponder this before the next release :) |
anderseknert
approved these changes
Feb 14, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* rules: Add double negative rule * Correct link for related resources Signed-off-by: Charlie Egan <charlie@styra.com> Co-authored-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anderseknert this is 'your' rule so feel free to rebase this branch and take the commit.