Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in external-reference #563

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

anderseknert
Copy link
Member

@anderseknert anderseknert commented Feb 20, 2024

By taking variables declared in the return value into account when counting vars in scope.

Fixes #560

By taking variables declared in the return value
into account when counting vars in scope.

Fixes #560

Signed-off-by: Anders Eknert <anders@styra.com>
@anderseknert anderseknert merged commit 6ecc6af into main Feb 20, 2024
3 checks passed
@anderseknert anderseknert deleted the external-ref-fp branch February 20, 2024 12:44
srenatus pushed a commit to srenatus/regal that referenced this pull request Oct 1, 2024
By taking variables declared in the return value
into account when counting vars in scope.

Fixes StyraInc#560

Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge case in external reference rule when using = for assignment
2 participants