Fix prefer-some-in-iteration false positive on contains check
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
some-in-iteration-contains-fp
branch
from
5a199bf
to
f02fc7f
Compare
srenatus
approved these changes
Feb 23, 2024
When scalar values are on one side of e.g. `5 == input[_]` we should not recommending using `some`, but `in`. Fixes #566 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
some-in-iteration-contains-fp
branch
from
f02fc7f
to
4c7efec
Compare
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
…aInc#574) When scalar values are on one side of e.g. `5 == input[_]` we should not recommending using `some`, but `in`. Fixes StyraInc#566 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scalar values are on one side of e.g.
5 == input[_]we should not recommending usingsome, butin.Fixes #566