Language server initialisation adjustments #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is unused and behaves differently in different clients, see #578 Signed-off-by: Charlie Egan <charlie@styra.com>
This disables features that make use of the Root URI, namely the linting of more than one file, use of config file, and linting of unopened files. This is only used when a language server is started with no client root URI. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
Feb 26, 2024
| } | ||
|
|
||
| // attempt to load the config as it is found on disk | ||
| file, err := config.FindConfig(strings.TrimPrefix(l.clientRootURI, "file://")) |
There was a problem hiding this comment.
Was file:// not an issue on windows? Or it’s not applicable here?
There was a problem hiding this comment.
Hmm, need to double check this. Will save a TODO for this.
charlieegan3
added a commit
to charlieegan3/vscode-opa
that referenced
this pull request
Mar 1, 2024
When VS code starts, there is an issue where the configuration is 'changed' multiple times during start-up. This happened too quickly for the activatedRegal function to reliably test if regal was running already and caused many servers to be started. This meant that sometimes messages would be duplicated since many servers would send the same message. The minimum regal version has also been bumped, to contain fixes for non-workspaced vs code instances. (see StyraInc/regal#580) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
charlieegan3
added a commit
to charlieegan3/vscode-opa
that referenced
this pull request
Mar 1, 2024
When VS code starts, there is an issue where the configuration is 'changed' multiple times during start-up. This happened too quickly for the activatedRegal function to reliably test if regal was running already and caused many servers to be started. This meant that sometimes messages would be duplicated since many servers would send the same message. The minimum regal version has also been bumped, to contain fixes for non-workspaced vs code instances. (see StyraInc/regal#580) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com>
anderseknert
pushed a commit
to open-policy-agent/vscode-opa
that referenced
this pull request
Mar 1, 2024
When VS code starts, there is an issue where the configuration is 'changed' multiple times during start-up. This happened too quickly for the activatedRegal function to reliably test if regal was running already and caused many servers to be started. This meant that sometimes messages would be duplicated since many servers would send the same message. The minimum regal version has also been bumped, to contain fixes for non-workspaced vs code instances. (see StyraInc/regal#580) Signed-off-by: Charlie Egan <charlieegan3@users.noreply.github.com> Co-authored-by: Charlie Egan <charlieegan3@users.noreply.github.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* Drop InitializationOption from config this is unused and behaves differently in different clients, see StyraInc#578 Signed-off-by: Charlie Egan <charlie@styra.com> * Run LS in workspaceless mode when no root URI set This disables features that make use of the Root URI, namely on the linting of more than one file, use of config file, and linting of unopened files. This is only used when a language server is started with no client root URI. Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes: