lsp: Support file ignore config #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
force-pushed
the
lsp-ignore-files
branch
from
f1c1f41
to
b8c3556
Compare
Fixes: #589 This PR makes the filtering logic support a new rootDir prefix. When set, this will be stripped from file paths before testing their ignore status. I have tried to add tests to explain the new functionality. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
lsp-ignore-files
branch
from
b8c3556
to
48ef185
Compare
anderseknert
approved these changes
Apr 3, 2024
| @@ -12,7 +12,12 @@ import ( | |||
| "github.com/open-policy-agent/opa/bundle" | |||
| ) | |||
|
|
|||
| func FilterIgnoredPaths(paths, ignore []string, checkFileExists bool) ([]string, error) { | |||
| func FilterIgnoredPaths(paths, ignore []string, checkFileExists bool, rootDir string) ([]string, error) { | |||
There was a problem hiding this comment.
This is a breaking change, I guess, but hopefully not one anyone has come to rely on 😬 And if they did, it should be easy to fix.
Long term, I'm hoping we can have this removed entirely in favor of doing all filtering / config work in Rego, so good thing we have that beta disclaimer in the readme stil 😅
There was a problem hiding this comment.
Discussed on slack, after being unable to find any public integrations based on this we have opted to merge and leave a note in the release.
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Fixes: StyraInc#589 This PR makes the filtering logic support a new rootDir prefix. When set, this will be stripped from file paths before testing their ignore status. I have tried to add tests to explain the new functionality. Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #589
This PR makes the filtering logic support a new rootDir prefix. When set, this will be stripped from file paths before testing their ignore status.
Screen.Recording.2024-04-03.at.15.35.31.mov