Code action for OPA fmt #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Eknert <anders@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
force-pushed
the
code-action-fmt
branch
from
e6ecb4c
to
a3a6a42
Compare
srenatus
reviewed
Apr 10, 2024
| func FmtCommand(args []string) Command { | ||
| return Command{ | ||
| Title: "Format using opa-fmt", | ||
| Command: "regal.fmt", |
There was a problem hiding this comment.
Would you happen to know if there's a well-known command name or some other mechanism at play when an IDE/editor does "format on save" via LSP? What I'm wondering is what we'd need to do to have that just work. If it's command-name-based, we'd need to adjust this. But I know way too little about LSP myself 😅
There was a problem hiding this comment.
https://zed.dev/docs/configuring-zed#lsp this makes me think there's no convention...
There was a problem hiding this comment.
And yeah, that'll be trivial to add with this code in place as the response is the same.
srenatus
approved these changes
Apr 10, 2024
internal/lsp/server.go
Outdated
| @@ -121,6 +134,8 @@ func (l *LanguageServer) Handle( | |||
| return struct{}{}, nil | |||
| } | |||
|
|
|||
| fmt.Fprintf(l.errorLog, "%s\n", string(util.MustMarshalJSON(req))) | |||
There was a problem hiding this comment.
Suggested change
| fmt.Fprintf(l.errorLog, "%s\n", string(util.MustMarshalJSON(req))) | |
| fmt.Fprintln(l.errorLog, string(util.MustMarshalJSON(req))) |
(if it was desired to keep this line)
There was a problem hiding this comment.
Thanks, I don't think we need this tbh. Will remove, I have some ideas to improve the logging in the server, but will do in another PR.
| for _, diag := range params.Context.Diagnostics { | ||
| if diag.Code == "opa-fmt" { | ||
| actions = append(actions, CodeAction{ | ||
| Title: "Format using opa fmt", |
This is not really the best place to do this, so I'll do it properly in another PR. Signed-off-by: Charlie Egan <charlie@styra.com>
This is now used where it's used in the spec. Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
Apr 10, 2024
charlieegan3
added a commit
that referenced
this pull request
Apr 10, 2024
While working on #630, I needed to be able to see requests, responses and notifications to the server from the client and from the server to the client. I learned that there is functionality in the jsonrpc2 lib that we use to do this nicely. This PR implements a new logging configuration to make use of this using an adapted version of the LogMessage function that is found in the library and using the OnRecv and OnSend functions. Because of this, I have removed the logging responsibility from the server and moved it to the connection. The server now should log errors only and that should be the default mode of operation. Enabling verbose logging will show you all messages being sent on the connection. ExcludeMethods and IncludeMethods can be used to filter the stream of messages when you are interested in monitoring or ignoring certain flows of messages. I know that this will be useful for me and I hope that this is a sensible enough way to do this overall. Signed-off-by: Charlie Egan <charlie@styra.com>
Merged
charlieegan3
added a commit
that referenced
this pull request
Apr 10, 2024
* Refactor LSP logging While working on #630, I needed to be able to see requests, responses and notifications to the server from the client and from the server to the client. I learned that there is functionality in the jsonrpc2 lib that we use to do this nicely. This PR implements a new logging configuration to make use of this using an adapted version of the LogMessage function that is found in the library and using the OnRecv and OnSend functions. Because of this, I have removed the logging responsibility from the server and moved it to the connection. The server now should log errors only and that should be the default mode of operation. Enabling verbose logging will show you all messages being sent on the connection. ExcludeMethods and IncludeMethods can be used to filter the stream of messages when you are interested in monitoring or ignoring certain flows of messages. I know that this will be useful for me and I hope that this is a sensible enough way to do this overall. Signed-off-by: Charlie Egan <charlie@styra.com> * Inline logging config Signed-off-by: Charlie Egan <charlie@styra.com> * Remove VerboseLogging server option for good Also use an io.Writer for errors Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* WIP code action Signed-off-by: Anders Eknert <anders@styra.com> * Support sending of workspace/applyEdits Signed-off-by: Charlie Egan <charlie@styra.com> * Fix linter errors Signed-off-by: Charlie Egan <charlie@styra.com> * Remove logging of unknown messages This is not really the best place to do this, so I'll do it properly in another PR. Signed-off-by: Charlie Egan <charlie@styra.com> * Add OptionalVersionedTextDocumentIdentifier This is now used where it's used in the spec. Signed-off-by: Charlie Egan <charlie@styra.com> * Add license for ComputeEdits Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Anders Eknert <anders@styra.com> Signed-off-by: Charlie Egan <charlie@styra.com> Co-authored-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
* Refactor LSP logging While working on StyraInc#630, I needed to be able to see requests, responses and notifications to the server from the client and from the server to the client. I learned that there is functionality in the jsonrpc2 lib that we use to do this nicely. This PR implements a new logging configuration to make use of this using an adapted version of the LogMessage function that is found in the library and using the OnRecv and OnSend functions. Because of this, I have removed the logging responsibility from the server and moved it to the connection. The server now should log errors only and that should be the default mode of operation. Enabling verbose logging will show you all messages being sent on the connection. ExcludeMethods and IncludeMethods can be used to filter the stream of messages when you are interested in monitoring or ignoring certain flows of messages. I know that this will be useful for me and I hope that this is a sensible enough way to do this overall. Signed-off-by: Charlie Egan <charlie@styra.com> * Inline logging config Signed-off-by: Charlie Egan <charlie@styra.com> * Remove VerboseLogging server option for good Also use an io.Writer for errors Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-04-10.at.11.31.26.mov