Implement textDocument/formatting #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
approved these changes
Apr 11, 2024
charlieegan3
force-pushed
the
formatting
branch
from
12a89a8 to
f7f161a
Compare
Although currently disabled in server capabilities while we work out how this should work with VS Code, where there is already a client-side formatter registered. Signed-off-by: Anders Eknert <anders@styra.com>
charlieegan3
force-pushed
the
formatting
branch
from
f7f161a to
df33bca
Compare
charlieegan3
added a commit
that referenced
this pull request
Apr 11, 2024
In #641 support was added to handle textDocument/formatting requests from clients. However, the functionality was disabled for fear that users would see a confusing message: #638 (comment) In open-policy-agent/vscode-opa#148 the regal formatter will be used if the user has enabled regal and opa fmt will be used if not. This means that there is only ever one formatter available for rego and the user will see no message. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
that referenced
this pull request
Apr 11, 2024
In #641 support was added to handle textDocument/formatting requests from clients. However, the functionality was disabled for fear that users would see a confusing message: #638 (comment) In open-policy-agent/vscode-opa#148 the regal formatter will be used if the user has enabled regal and opa fmt will be used if not. This means that there is only ever one formatter available for rego and the user will see no message. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
pushed a commit
that referenced
this pull request
Apr 11, 2024
In #641 support was added to handle textDocument/formatting requests from clients. However, the functionality was disabled for fear that users would see a confusing message: #638 (comment) In open-policy-agent/vscode-opa#148 the regal formatter will be used if the user has enabled regal and opa fmt will be used if not. This means that there is only ever one formatter available for rego and the user will see no message. Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Although currently disabled in server capabilities while we work out how this should work with VS Code, where there is already a client-side formatter registered. Signed-off-by: Anders Eknert <anders@styra.com>
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
In StyraInc#641 support was added to handle textDocument/formatting requests from clients. However, the functionality was disabled for fear that users would see a confusing message: StyraInc#638 (comment) In open-policy-agent/vscode-opa#148 the regal formatter will be used if the user has enabled regal and opa fmt will be used if not. This means that there is only ever one formatter available for rego and the user will see no message. Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although currently disabled in server capabilities while we work out how this should work with VS Code, where there is already a client-side formatter registered.