lsp: Accept but ignore cancelled requests #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have not been able to work out why these are sent but they don't seem to impact the running functionality of the server and supporting them seems to be optional. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#dollarRequests For now, this updates the server to do nothing when receiving such a request. This avoids some log lines that we don't do anything about. I would like to come back to this though as it seems like there's more here that we might be missing. So it has been labelled as TODO. Signed-off-by: Charlie Egan <charlie@styra.com>
|
logTrace and setTrace are similar, but I am more optimistic that we can add support for them quickly. |
anderseknert
approved these changes
Apr 11, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
I have not been able to work out why these are sent but they don't seem to impact the running functionality of the server and supporting them seems to be optional. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#dollarRequests For now, this updates the server to do nothing when receiving such a request. This avoids some log lines that we don't do anything about. I would like to come back to this though as it seems like there's more here that we might be missing. So it has been labelled as TODO. Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not been able to work out why these are sent but they don't seem to impact the running functionality of the server and supporting them seems to be optional.
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#dollarRequests
For now, this updates the server to do nothing when receiving such a request. This avoids some log lines that we don't do anything about.
I would like to come back to this though as it seems like there's more here that we might be missing. So it has been labelled as TODO.