lsp: More graceful shutdown #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been erroring on shutdown requests as they have no params set. This PR changes that and makes sure the server waits for the exit message before closing the connection. The client shows: ``` [Error - 18:21:10] Server process exited with code 0. ``` This is an odd one based on the code here: https://sourcegraph.com/npm/vscode-languageclient@492942af8005ce98cbd47721d4a7790a0310d4e3/-/blob/lib/node/main.js?L474:37-474:68 It would look like we exit ok here, but that seems to be perhaps parsed as "0" the string... One for another day. Signed-off-by: Charlie Egan <charlie@styra.com>
srenatus
approved these changes
Apr 23, 2024
anderseknert
approved these changes
Apr 23, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
We have been erroring on shutdown requests as they have no params set. This PR changes that and makes sure the server waits for the exit message before closing the connection. The client shows: ``` [Error - 18:21:10] Server process exited with code 0. ``` This is an odd one based on the code here: https://sourcegraph.com/npm/vscode-languageclient@492942af8005ce98cbd47721d4a7790a0310d4e3/-/blob/lib/node/main.js?L474:37-474:68 It would look like we exit ok here, but that seems to be perhaps parsed as "0" the string... One for another day. Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been erroring on shutdown requests as they have no params set. This PR changes that and makes sure the server waits for the exit message before closing the connection.
The client shows:
This is an odd one based on the code here:
https://sourcegraph.com/npm/vscode-languageclient@492942af8005ce98cbd47721d4a7790a0310d4e3/-/blob/lib/node/main.js?L474:37-474:68
It would look like we exit ok here, but that seems to be perhaps parsed as "0" the string... One for another day.
Before:
Screen.Recording.2024-04-23.at.18.24.26.mov
After
Screen.Recording.2024-04-23.at.18.17.44.mov