lsp: Provide data ref completions in rules #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: StyraInc#753 Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
May 29, 2024
| // we are not interested in packages here, only the rules | ||
| for uri, refs := range c.GetAllFileRefs() { | ||
| for _, ref := range refs { | ||
| // we are not interested in packages here, only rules |
There was a problem hiding this comment.
I guess there are a few cases where you might want to refer to a package even in a rule body, like when doing dynamic policy composition:
some policy
some decision in data.policies[policy].deny
and so on... but I guess that's uncommon enough that it's still better to only suggest rules as a default.
There was a problem hiding this comment.
Hmm, that is a thought. I guess this provide is called rulers and is already quite complex. I'd like to consider that for a new provider.
Issue here: #771
| symbol = completion.Function | ||
| detail = "Function" | ||
| case ref.Description == "Partial": | ||
| detail = "Partial path suggestion, continue typing for more suggestions." |
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
Fixes: StyraInc#753 Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #753
Screen.Recording.2024-05-29.at.12.17.08.mov