-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache rq binary #820
Cache rq binary #820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was fast! LGTM, but I suspect the which
command is redundant?
.github/workflows/build.yaml
Outdated
uses: actions/cache@v3 | ||
with: | ||
path: ~/go/bin/rq | ||
key: ${{ runner.os }}-${{ runner.arch }}-go-rq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding a version? I guess we can worry about that when there's an rq version we want and it's not getting here because of the cache 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... I did wonder about that. Added now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Charlie Egan <charlie@styra.com>
* Cache rq binary Signed-off-by: Charlie Egan <charlie@styra.com> * Cache v4 Signed-off-by: Charlie Egan <charlie@styra.com> * Fix typo Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Fixes #818