Completion suggestions for variables in local scope #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first provider that is using Rego policy to determine suggestions! That makes the PR more extensive than normally, but much of this will be reusable for future providers, or even existing ones we may choose to convert. Fixes #792 Signed-off-by: Anders Eknert <anders@styra.com>
| func TestPolicyProvider(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| locals := NewPolicy() |
There was a problem hiding this comment.
I wonder if there's a way here to make it so that only one of the Rego providers is run, so that when we have more, testing them individually is easier.
There was a problem hiding this comment.
The Rego providers are "all" (well, in the future anyway) thoroughly tested in Rego. What we do here should be closer to an integration test... but you're still right — it'd be good to be able to have at least a very basic such test for each provider. Let's look into that as we add more.
charlieegan3
approved these changes
Jun 17, 2024
srenatus
pushed a commit
to srenatus/regal
that referenced
this pull request
Oct 1, 2024
This is the first provider that is using Rego policy to determine suggestions! That makes the PR more extensive than normally, but much of this will be reusable for future providers, or even existing ones we may choose to convert. Fixes StyraInc#792 Signed-off-by: Anders Eknert <anders@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first provider that is using Rego policy to determine suggestions!
That makes the PR more extensive than normally, but much of this will be reusable for future providers, or even existing ones we may choose to convert.
Fixes #792